[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 04/11] target/arm: Don't set INSN_ARM_BE32 for CONFIG
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PULL 04/11] target/arm: Don't set INSN_ARM_BE32 for CONFIG_USER_ONLY |
Date: |
Wed, 25 Oct 2017 14:30:49 +0200 |
This matches translator behaviour in arm_lduw_code.
Fixes: https://bugs.launchpad.net/qemu/+bug/1724485
Signed-off-by: Richard Henderson <address@hidden>
---
target/arm/cpu.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index 82dad0b721..a92d86faa0 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -477,6 +477,7 @@ static void arm_disas_set_info(CPUState *cpu,
disassemble_info *info)
{
ARMCPU *ac = ARM_CPU(cpu);
CPUARMState *env = &ac->env;
+ bool sctlr_b;
if (is_a64(env)) {
/* We might not be compiled with the A64 disassembler
@@ -491,7 +492,9 @@ static void arm_disas_set_info(CPUState *cpu,
disassemble_info *info)
} else {
info->print_insn = print_insn_arm;
}
- if (bswap_code(arm_sctlr_b(env))) {
+
+ sctlr_b = arm_sctlr_b(env);
+ if (bswap_code(sctlr_b)) {
#ifdef TARGET_WORDS_BIGENDIAN
info->endian = BFD_ENDIAN_LITTLE;
#else
@@ -499,9 +502,11 @@ static void arm_disas_set_info(CPUState *cpu,
disassemble_info *info)
#endif
}
info->flags &= ~INSN_ARM_BE32;
- if (arm_sctlr_b(env)) {
+#ifndef CONFIG_USER_ONLY
+ if (sctlr_b) {
info->flags |= INSN_ARM_BE32;
}
+#endif
}
uint64_t arm_cpu_mp_affinity(int idx, uint8_t clustersz)
--
2.13.6
- [Qemu-devel] [PULL 00/11] Disassembler patches, Richard Henderson, 2017/10/25
- [Qemu-devel] [PULL 04/11] target/arm: Don't set INSN_ARM_BE32 for CONFIG_USER_ONLY,
Richard Henderson <=
- [Qemu-devel] [PULL 03/11] target/arm: Move BE32 disassembler fixup, Richard Henderson, 2017/10/25
- [Qemu-devel] [PULL 01/11] target/i386: Convert to disas_set_info hook, Richard Henderson, 2017/10/25
- [Qemu-devel] [PULL 02/11] target/ppc: Convert to disas_set_info hook, Richard Henderson, 2017/10/25
- [Qemu-devel] [PULL 06/11] disas: Support the Capstone disassembler library, Richard Henderson, 2017/10/25
- [Qemu-devel] [PULL 09/11] ppc: Support Capstone in disas_set_info, Richard Henderson, 2017/10/25
- [Qemu-devel] [PULL 07/11] i386: Support Capstone in disas_set_info, Richard Henderson, 2017/10/25
- [Qemu-devel] [PULL 05/11] disas: Remove unused flags arguments, Richard Henderson, 2017/10/25
- [Qemu-devel] [PULL 11/11] disas: Add capstone as submodule, Richard Henderson, 2017/10/25
- [Qemu-devel] [PULL 08/11] arm: Support Capstone in disas_set_info, Richard Henderson, 2017/10/25
- [Qemu-devel] [PULL 10/11] disas: Remove monitor_disas_is_physical, Richard Henderson, 2017/10/25