Re: [Qemu-devel] [PULL 00/11] Disassembler patches

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PULL 00/11] Disassembler patches
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
1b87049c52 disas: Add capstone as submodule
1a149369df disas: Remove monitor_disas_is_physical
6c35e6706c ppc: Support Capstone in disas_set_info
52e10752ca arm: Support Capstone in disas_set_info
4b31f39e81 i386: Support Capstone in disas_set_info
279e046dc1 disas: Support the Capstone disassembler library
4da4345ecf disas: Remove unused flags arguments
9e561441a6 target/arm: Don't set INSN_ARM_BE32 for CONFIG_USER_ONLY
9c25d63ac2 target/arm: Move BE32 disassembler fixup
6836256946 target/ppc: Convert to disas_set_info hook
667b551cc7 target/i386: Convert to disas_set_info hook

=== OUTPUT BEGIN ===
Checking PATCH 1/11: target/i386: Convert to disas_set_info hook...
Checking PATCH 2/11: target/ppc: Convert to disas_set_info hook...
Checking PATCH 3/11: target/arm: Move BE32 disassembler fixup...
ERROR: space prohibited between function name and open parenthesis '('
#46: FILE: disas/arm.c:3824:
+      status = arm_read_memory (addr, (bfd_byte *)b, 2, info);

ERROR: space prohibited between function name and open parenthesis '('
#55: FILE: disas/arm.c:3896:
+      status = arm_read_memory (pc, (bfd_byte *)b, size, info);

ERROR: space prohibited between function name and open parenthesis '('
#64: FILE: disas/arm.c:3913:
+      status = arm_read_memory (pc, (bfd_byte *)b, 4, info);

ERROR: space prohibited between function name and open parenthesis '('
#73: FILE: disas/arm.c:3929:
+      status = arm_read_memory (pc, (bfd_byte *)b, 2, info);

ERROR: code indent should never use tabs
#82: FILE: disas/arm.c:3943:
+^I      status = arm_read_memory (pc + 2, (bfd_byte *)b, 2, info);$

ERROR: space prohibited between function name and open parenthesis '('
#82: FILE: disas/arm.c:3943:
+             status = arm_read_memory (pc + 2, (bfd_byte *)b, 2, info);

total: 6 errors, 0 warnings, 107 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/11: target/arm: Don't set INSN_ARM_BE32 for CONFIG_USER_ONLY...
Checking PATCH 5/11: disas: Remove unused flags arguments...
Checking PATCH 6/11: disas: Support the Capstone disassembler library...
Checking PATCH 7/11: i386: Support Capstone in disas_set_info...
Checking PATCH 8/11: arm: Support Capstone in disas_set_info...
Checking PATCH 9/11: ppc: Support Capstone in disas_set_info...
Checking PATCH 10/11: disas: Remove monitor_disas_is_physical...
Checking PATCH 11/11: disas: Add capstone as submodule...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden