qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCHv2 1/4] sun4m: implement IOMMU translation using


From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-devel] [PATCHv2 1/4] sun4m: implement IOMMU translation using IOMMU memory region
Date: Fri, 27 Oct 2017 12:37:29 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0

On 10/27/2017 09:19 AM, Mark Cave-Ayland wrote:
[...]
> +/* Called from RCU critical section */
> +static IOMMUTLBEntry sun4m_translate_iommu(IOMMUMemoryRegion *iommu,
> +                                           hwaddr addr,
> +                                           IOMMUAccessFlags flags)
> +{
> +    IOMMUState *is = container_of(iommu, IOMMUState, iommu);
> +    hwaddr page, pa;
> +    int is_write = (flags & IOMMU_WO) ? 1 : 0;
> +    uint32_t pte;
> +    IOMMUTLBEntry ret = {
> +        .target_as = &address_space_memory,
> +        .iova = 0,
> +        .translated_addr = 0,
> +        .addr_mask = ~(hwaddr)0,

I never thought of it! I would have write (hwaddr)~0 but your way is
much cleaner.

> +        .perm = IOMMU_NONE,
> +    };
[...]



reply via email to

[Prev in Thread] Current Thread [Next in Thread]