qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3] s390-ccw: print carriage return with new lin


From: Halil Pasic
Subject: Re: [Qemu-devel] [PATCH v3] s390-ccw: print carriage return with new lines
Date: Fri, 27 Oct 2017 17:55:49 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0


On 10/27/2017 05:47 PM, Collin L. Walling wrote:
>>
> 
> I wanted to do the same, however str is void can cannot be indexed directly.
> We'd have to do some nasty casting first, so I figured having *p made things
> look cleaner.

I did not consider that, sorry. (One could rename p to str AFAIR to express
that we are actually scanning the parameter and that the local is just for
avoiding the cast). But I really think we should go with Alex's proposal.

Halil




reply via email to

[Prev in Thread] Current Thread [Next in Thread]