qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCHv3 02/13] sparc32_dma: split esp and le into sepa

From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-devel] [PATCHv3 02/13] sparc32_dma: split esp and le into separate DMA devices
Date: Fri, 27 Oct 2017 13:26:53 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 
On 10/20/2017 09:41 AM, Mark Cave-Ayland wrote:
>>> -    dev = qdev_create(NULL, "sparc32-dma-device");
>>> +    dev = qdev_create(NULL, is_ledma ? "sparc32-ledma" : "sparc32-espdma");
>>
>> TYPE_SPARC32_LEDMA_DEVICE and TYPE_SPARC32_ESPDMA_DEVICE?
> 
> Again please note that this patch is an intermediate step and the type
> is switched over to use the macro later in the patchset when the type
> macro is eventually moved over to sparc32_dma.h.

Oops sorry! I missed this mail while reviewing your v4.
reply via email to
[Prev in Thread] Current Thread [Next in Thread]