[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/4] build: allow automatic git submodule upd
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/4] build: allow automatic git submodule updates to be disabled |
Date: |
Sat, 28 Oct 2017 07:28:11 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 10/27/2017 03:14 PM, Daniel P. Berrange wrote:
> Some people building QEMU use VPATH builds where the source directory is on a
> read-only volume. In such a case 'scripts/git-submodules.sh update' will
> always
> fail and users are required to run it manually themselves on their original
> writable source directory.
>
> @@ -1297,11 +1299,15 @@ for opt do
> ;;
> --with-git=*) git="$optarg"
> ;;
> + --enable-git-update) git_update=yes
> + ;;
> + --disable-git-update) git_update=no
> + ;;
Consistent, which makes...
> *)
> echo "ERROR: unknown option $opt"
> echo "Try '$0 --help' for more information"
> exit 1
> - ;;
> + ;;
...this an unrelated whitespace change?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 0/4] Various improvements to submodule handling, Daniel P. Berrange, 2017/10/27
- [Qemu-devel] [PATCH v2 1/4] build: allow setting a custom GIT binary for transparent proxying, Daniel P. Berrange, 2017/10/27
- [Qemu-devel] [PATCH v2 2/4] build: don't create temporary files in source dir, Daniel P. Berrange, 2017/10/27
- [Qemu-devel] [PATCH v2 4/4] build: don't fail if given a git submodule which does not exist, Daniel P. Berrange, 2017/10/27
- [Qemu-devel] [PATCH v2 3/4] build: allow automatic git submodule updates to be disabled, Daniel P. Berrange, 2017/10/27
- Re: [Qemu-devel] [PATCH v2 3/4] build: allow automatic git submodule updates to be disabled,
Eric Blake <=
- Re: [Qemu-devel] [PATCH v2 0/4] Various improvements to submodule handling, Eric Blake, 2017/10/28