Re: [Qemu-devel] [PATCH] AMD Processor Topology Information

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH] AMD Processor Topology Information
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
b10ea7470d AMD Processor Topology Information

=== OUTPUT BEGIN ===
Checking PATCH 1/1: AMD Processor Topology Information...
ERROR: space prohibited before that close parenthesis ')'
#26: FILE: target/i386/cpu.c:3119:
+            *ebx = (cs->nr_threads - 1 ) << 8 | cpu->core_id;

ERROR: line over 90 characters
#44: FILE: target/i386/cpu.c:3796:
+    if (!IS_INTEL_CPU(env) && cs->nr_threads > 1 && !ht_warned && 
(env->cpuid_version & 0xFF00F00) != 0x800F00) {

total: 2 errors, 0 warnings, 30 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden