Re: [Qemu-devel] [PULL 00/51] tcg queued patches

[Thomas Huth]

On 25.10.2017 11:34, Richard Henderson wrote:
> Primarily Emilio's work toward removing tb_lock, with fixes.
> But there are some other tcg-related patches that are queued.
> 
> r~
> 
> The following changes since commit 3d7196d43bfe12efe98568cb60057e273652b99b:
> 
>   Merge remote-tracking branch 
> 'remotes/kraxel/tags/usb-20171023-pull-request' into staging (2017-10-24 
> 16:05:57 +0100)
> 
> are available in the git repository at:
> 
>   git://github.com/rth7680/qemu.git tags/pull-tcg-20171025
> 
> for you to fetch changes up to cc689485ee3e9dca05765326ee8fd619a6ec48f0:
> 
>   translate-all: exit from tb_phys_invalidate if qht_remove fails (2017-10-24 
> 13:53:42 -0700)
> 
> ----------------------------------------------------------------
> TCG patch queue
> 
> ----------------------------------------------------------------
> Emilio G. Cota (25):
>       tcg: define CF_PARALLEL and use it for TB hashing along with 
> CF_COUNT_MASK
>       tcg: convert tb->cflags reads to tb_cflags(tb)
>       target/arm: check CF_PARALLEL instead of parallel_cpus
>       target/hppa: check CF_PARALLEL instead of parallel_cpus
>       target/i386: check CF_PARALLEL instead of parallel_cpus
>       target/m68k: check CF_PARALLEL instead of parallel_cpus
>       target/s390x: check CF_PARALLEL instead of parallel_cpus
>       target/sh4: check CF_PARALLEL instead of parallel_cpus
>       target/sparc: check CF_PARALLEL instead of parallel_cpus
>       tcg: check CF_PARALLEL instead of parallel_cpus
>       cpu-exec: lookup/generate TB outside exclusive region during step_atomic
>       translate-all: use a binary search tree to track TBs in TBContext
>       exec-all: rename tb_free to tb_remove
>       translate-all: report correct avg host TB size
>       tcg: take tb_ctx out of TCGContext
>       tcg: define tcg_init_ctx and make tcg_ctx a pointer
>       gen-icount: fold exitreq_label into TCGContext
>       tcg: introduce **tcg_ctxs to keep track of all TCGContext's
>       tcg: distribute profiling counters across TCGContext's
>       tcg: allocate optimizer temps with tcg_malloc
>       osdep: introduce qemu_mprotect_rwx/none
>       translate-all: use qemu_protect_rwx/none helpers
>       tcg: introduce regions to split code_gen_buffer
>       tcg: enable multiple TCG contexts in softmmu

Seems like something in this patch series broke a couple of ARM boards
(smdkc210, nuri, raspi2, xlnx-ep108 and xlnx-zcu102). With current
master branch, I just get this error:

$ aarch64-softmmu/qemu-system-aarch64  -machine raspi2
**
ERROR:/home/thuth/devel/qemu/tcg/tcg.c:537:tcg_register_thread:
assertion failed: (n < max_cpus)
Aborted (core dumped)

Could you please have a look at this?

 Thanks,
  Thomas