[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4] configure: do CC check before verifying host
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v4] configure: do CC check before verifying host CPU |
Date: |
Wed, 1 Nov 2017 23:41:06 +0000 |
On 1 November 2017 at 19:46, Daniel Henrique Barboza
<address@hidden> wrote:
> On 11/01/2017 05:41 PM, Peter Maydell wrote:
>> I think that currently we try to make "--help" work
>> even if you don't have a working C compiler. Does this
>> break that?
>
> Just checked, configure --help isn't broken with this change:
Did you test with gcc uninstalled again? It's hard to see
how it could work -- if the compile test fails we'll call
error_exit, which (as the name suggests) exits. Your patch
moves the compiler check from after we handle --help to
before it...
thanks
-- PMM