Re: [Qemu-devel] [PATCH v2 1/2] ui/cocoa.m: move ungrab to ctrl-alt-g

[Peter Maydell]

On 5 October 2017 at 15:55, John Arbuckle <address@hidden> wrote:
> Currently the cocoa user interface relys on the user pushing control-alt to 
> ungrab the mouse. This is patch changes the key combination to control-alt-g 
> to be in line with the GTK user interface.
>
> signed-off-by: John Arbuckle <address@hidden>
> ---

> +
> +                    // release the mouse grab
> +                    case Q_KEY_CODE_G:
> +                        [self ungrabMouse];
> +                        break;
>                  }

Testing this I have found that it makes the grab key be
"ctrl+alt+ the key labelled 'g'", even if in the
OSX host keyboard mapping that key doesn't produce the
letter 'g'. This is in contrast to for instance the menu
accelerators which honour the host keyboard layout, and
it's also not what the GTK UI does. So I think we need
to fix that.

thanks
-- PMM