Re: [Qemu-devel] [PATCH v13 3/6] qmp: factor out throttle code to reuse code

[Pradeep Jagadeesh]

On 10/13/2017 4:29 PM, Alberto Garcia wrote:
> On Mon 02 Oct 2017 04:33:29 PM CEST, Pradeep Jagadeesh wrote:
>
> > -    if (arg->has_iops_rd_max_length) {
> > -        cfg.buckets[THROTTLE_OPS_READ].burst_length = arg->iops_rd_max_length;
> > -    }
> > -    if (arg->has_iops_wr_max_length) {
> > -        cfg.buckets[THROTTLE_OPS_WRITE].burst_length = arg->iops_wr_max_length;
> > -    }
> > -
> > -    if (arg->has_iops_size) {
> > -        cfg.op_size = arg->iops_size;
> > -    }
>
> The old code takes an empty ThrottleConfig, and initializes it using the
> values from a BlockIOThrottle structure...
>
> > +    tlimit = qapi_BlockIOThrottle_base(arg);
> > +    throttle_config_to_limits(&cfg, tlimit);
>
> ...but the new code does the exact opposite (?).

Its a mistake of a call. It should be throttle_limits_to_config()
I will change it.

Regards,
Pradeep

> Berto