[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tcg/mips: make some functions inline.
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH] tcg/mips: make some functions inline. |
|
Date: |
Thu, 2 Nov 2017 12:43:16 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 11/02/2017 12:23 PM, address@hidden wrote:
> No, :) Just found some of these functions are inline and others are not when
> reading
> the code, the style looks inconsistent.
My preference would be to remove them all.
> Besides, The compiler may make default inline choices for some functions, but
> may
> not for some cases(some longer ones). Adding inline manually can guarantee
> and
> not hurt. :)
The longer ones in particular should *not* be inline, so that we don't expand
the size of the code unnecessarily. Which *can* hurt.
r~