Re: [Qemu-devel] [PATCH v6 18/25] block: Add sgfnt_runtime_opts to BlockDriver

[Max Reitz]

On 2017-11-02 17:11, Alberto Garcia wrote:
> On Fri 29 Sep 2017 06:53:40 PM CEST, Max Reitz wrote:
>>      QLIST_ENTRY(BlockDriver) list;
>> +
>> +    /* Pointer to a NULL-terminated array of names of significant options 
>> that
>> +     * can be specified for bdrv_open(). A significant option is one that
>> +     * changes the data of a BDS.
>> +     * If this pointer is NULL, the array is considered empty.
>> +     * "filename" and "driver" are always considered significant. */
>> +    const char *const *sgfnt_runtime_opts;
>>  };
> 
> Is sgfnt a common acronym? I actually had to look it up...

I'm open for other suggestions to shorten "significant". :-)

(Actually, I can't remember where I got it from.  I think I just made it
up, but then I don't know why I didn't use sgfcnt -- maybe because cnt
looks either like count (or like something else, but that's a different
matter)...?)

Max

>> +static const char *const iscsi_sgfnt_runtime_opts[] = {
>> +    "transport",
>> +    "portal",
>> +    "target",
>> +    "user",
>> +    "password",
>> +    "password-secret",
>> +    "lun",
>> +    "initiator-name",
>> +    "header-digest",
>> +
>> +    NULL
>> +};
> 
> Ideally it would be nice to have constants for all these options, but
> this is a pre-existing problem.
> 
> Reviewed-by: Alberto Garcia <address@hidden>
> 
> Berto
>

signature.asc
Description: OpenPGP digital signature