[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH WIP] replace numpy with struct
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH WIP] replace numpy with struct |
Date: |
Fri, 3 Nov 2017 11:24:42 +0000 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Thu, Oct 26, 2017 at 10:50:26AM -0300, Philippe Mathieu-Daudé wrote:
> Hi Joannah,
>
> The common subject to use is [RFC PATCH] instead of [PATCH WIP]
>
> On 10/26/2017 09:14 AM, Joannah Nanjekye wrote:
> > This patch replaces the use of numpy with the standard Library struct
> > module where possible.
>
> This seems a good idea but why?
I suggest adding this to the commit description:
Users tend to hit an ImportError when running analyze-migration.py due
to the numpy dependency. numpy functionality isn't actually used, just
binary serialization that the standard library 'struct' module already
provides. Removing the dependency allows the script to run
out-of-the-box.
> Do you have any performance improvements results to share?
>
> > Signed-off-by: Joannah Nanjekye <address@hidden>
> > ---
> >
> > scripts/analyze-migration.py | 19 ++++++++++++-------
> > 1 file changed, 12 insertions(+), 7 deletions(-)
I don't see a removal of "import numpy as np" so this script still
depends on numpy. Did you forget to sent further patches that you have
to remove the numpy dependency?
signature.asc
Description: PGP signature
- Re: [Qemu-devel] [PATCH WIP] replace numpy with struct,
Stefan Hajnoczi <=