Re: [Qemu-devel] [PATCH] build-sys: restrict vmcoreinfo to fw_cfg+dma capable targets

[Marc-André Lureau]

Hi

On Mon, Nov 6, 2017 at 12:58 PM, Thomas Huth <address@hidden> wrote:
> On 06.11.2017 12:53, Marc-André Lureau wrote:
>> vmcoreinfo is built for all targets. However, it requires fw_cfg with
>> DMA operations support (write operation). Restrict vmcoreinfo exposure
>> to architectures that are supporting FW_CFG_DMA, that is arm-virt and
>> x86 only atm.
>>
>> Signed-off-by: Marc-André Lureau <address@hidden>
>> ---
>>  default-configs/arm-softmmu.mak    | 2 ++
>>  default-configs/i386-softmmu.mak   | 1 +
>>  default-configs/x86_64-softmmu.mak | 1 +
>>  hw/misc/Makefile.objs              | 2 +-
>>  4 files changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/default-configs/arm-softmmu.mak 
>> b/default-configs/arm-softmmu.mak
>> index 5059d134c8..d37edc4312 100644
>> --- a/default-configs/arm-softmmu.mak
>> +++ b/default-configs/arm-softmmu.mak
>> @@ -130,3 +130,5 @@ CONFIG_SMBIOS=y
>>  CONFIG_ASPEED_SOC=y
>>  CONFIG_GPIO_KEY=y
>>  CONFIG_MSF2=y
>> +
>> +CONFIG_FW_CFG_DMA=y
>
> Maybe remove the empty line?
>

This file seems to be organized somehow, although it's hard to figure
out how for me at first glance ;) commenting sections would help.

> Apart from that, patch looks good to me, so:
>
> Reviewed-by: Thomas Huth <address@hidden>
>

thanks


-- 
Marc-André Lureau