Re: [Qemu-devel] [PATCH 01/18] Add definitions needed by file-op-9p.h for Windows

[Greg Kurz]

On Fri, 29 Sep 2017 13:13:06 +0200
Michael Fritscher <address@hidden> wrote:

> Signed-off-by: Michael Fritscher <address@hidden>
> ---
>  include/sysemu/os-win32.h | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/include/sysemu/os-win32.h b/include/sysemu/os-win32.h
> index ff18b23db1..15cc94513b 100644
> --- a/include/sysemu/os-win32.h
> +++ b/include/sysemu/os-win32.h
> @@ -196,4 +196,30 @@ ssize_t qemu_recv_wrap(int sockfd, void *buf, size_t 
> len, int flags);
>  ssize_t qemu_recvfrom_wrap(int sockfd, void *buf, size_t len, int flags,
>                             struct sockaddr *addr, socklen_t *addrlen);
> 
> +typedef uint32_t uid_t;
> +typedef uint32_t gid_t;
> +
> +/* from http://man7.org/linux/man-pages/man2/statfs.2.html */
> +typedef uint32_t __fsword_t;
> +typedef uint32_t fsblkcnt_t;
> +typedef uint32_t fsfilcnt_t;
> +
> +/* from linux/include/uapi/asm-generic/posix_types.h */
> +typedef struct {
> +    long __val[2];
> +} fsid_t;
> +
> +struct statfs {
> +    __fsword_t f_type;
> +    __fsword_t f_bsize;
> +    fsblkcnt_t f_blocks;
> +    fsblkcnt_t f_bfree;
> +    fsblkcnt_t f_bavail;
> +    fsfilcnt_t f_files;
> +    fsfilcnt_t f_ffree;
> +    fsid_t f_fsid;
> +    __fsword_t f_namelen;
> +    __fsword_t f_frsize;
> +    __fsword_t f_flags;
> +};
>  #endif

Since this statfs definition is likely to be only ever used by fsdev, I'm
wondering if all the related typedefs would better sit in fsdev/file-op-9p.h
directly (ie, move the lines to a #else block in the next patch).