Re: [Qemu-devel] [PATCH] tpm: Don't call tpm_cleanup unless CONFIG_TPM.

[Michael Tokarev]

19.10.2017 10:50, Richard W.M. Jones wrote:
> When compiling with --disable-tpm:
> 
>   ../vl.o: In function `main':
>   /home/rjones/d/qemu/vl.c:4908: undefined reference to `tpm_cleanup'
> 
> This appears to have been introduced in commit c37cacabf228
> ("tpm: Move tpm_cleanup() to right place").
> 

> index 0723835bbf..dbfd06d4bc 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -4905,7 +4905,9 @@ int main(int argc, char **argv, char **envp)
>      res_free();
>  
>      /* vhost-user must be cleaned up before chardevs.  */
> +#ifdef CONFIG_TPM
>      tpm_cleanup();
> +#endif

Maybe we can define it to an empty macro (or inline function) in
the header file instead?

/mjt