[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH] remove numpy dependency
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [RFC PATCH] remove numpy dependency |
Date: |
Mon, 6 Nov 2017 08:47:46 -0800 (PST) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [RFC PATCH] remove numpy dependency
Type: series
Message-id: address@hidden
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
d0c6cb1cd0 remove numpy dependency
=== OUTPUT BEGIN ===
Checking PATCH 1/1: remove numpy dependency...
WARNING: line over 80 characters
#58: FILE: scripts/analyze-migration.py:60:
+ return struct.unpack(read_format, buffer[0:(0 +
struct.calcsize(read_format))])
ERROR: line over 90 characters
#70: FILE: scripts/analyze-migration.py:313:
+ self.sdata = struct.unpack(self.sdtype, buffer[0:(0 +
struct.calcsize(self.sdtype))])
ERROR: line over 90 characters
#71: FILE: scripts/analyze-migration.py:314:
+ self.sdata = struct.unpack(self.udtype, buffer[0:(0 +
struct.calcsize(self.udtype))])
total: 2 errors, 1 warnings, 53 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden