[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 63/88] bsd-user/syscall: fix a memory leak on EF
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 63/88] bsd-user/syscall: fix a memory leak on EFAULT, use g_new() |
Date: |
Mon, 6 Nov 2017 16:06:14 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
Hi Michael,
Since there is no bsd-user maintainers, can you take this single patch
for 2.11? It fixes a memory leak.
Regards,
Phil.
On 10/06/2017 08:49 PM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> Kamil are you interested in maintaining bsd-user? :)
>
> bsd-user/syscall.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/bsd-user/syscall.c b/bsd-user/syscall.c
> index 66492aaf5d..9120cea61e 100644
> --- a/bsd-user/syscall.c
> +++ b/bsd-user/syscall.c
> @@ -227,7 +227,7 @@ static abi_long do_freebsd_sysctl(abi_ulong namep,
> int32_t namelen, abi_ulong ol
> void *hnamep, *holdp, *hnewp = NULL;
> size_t holdlen;
> abi_ulong oldlen = 0;
> - int32_t *snamep = g_malloc(sizeof(int32_t) * namelen), *p, *q, i;
> + int32_t *snamep, *p, *q, i;
> uint32_t kind = 0;
>
> if (oldlenp)
> @@ -239,6 +239,7 @@ static abi_long do_freebsd_sysctl(abi_ulong namep,
> int32_t namelen, abi_ulong ol
> if (!(holdp = lock_user(VERIFY_WRITE, oldp, oldlen, 0)))
> return -TARGET_EFAULT;
> holdlen = oldlen;
> + snamep = g_new(int32_t, namelen);
> for (p = hnamep, q = snamep, i = 0; i < namelen; p++, i++)
> *q++ = tswap32(*p);
> oidfmt(snamep, namelen, NULL, &kind);
>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH 63/88] bsd-user/syscall: fix a memory leak on EFAULT, use g_new(),
Philippe Mathieu-Daudé <=