Re: [Qemu-devel] [PATCH v2 23/28] tpm-tis: remove redundant 'tpm_tis:' in error messages

[Stefan Berger]

On 11/06/2017 01:39 PM, Marc-André Lureau wrote:
> The reported error message is already prefixed with the -device
> name & arguments.
>
> Before:
> qemu-system-x86_64: -device tpm-tis,id=foo,tpmdev=foo,irq=21: tpm_tis: IRQ 21 
> is outside valid range of 0 to 15
>
> After:
> qemu-system-x86_64: -device tpm-tis,id=foo,tpmdev=foo,irq=21: IRQ 21 is outside 
> valid range of 0 to 15
>
> Signed-off-by: Marc-André Lureau <address@hidden>

Reviewed-by: Stefan Berger <address@hidden>

> ---
>   hw/tpm/tpm_tis.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c
> index d313347144..175785b9c4 100644
> --- a/hw/tpm/tpm_tis.c
> +++ b/hw/tpm/tpm_tis.c
> @@ -1059,8 +1059,8 @@ static void tpm_tis_realizefn(DeviceState *dev, Error 
> **errp)
>
>       s->be_driver = qemu_find_tpm_be(s->backend);
>       if (!s->be_driver) {
> -        error_setg(errp, "tpm_tis: backend driver with id %s could not be "
> -                   "found", s->backend);
> +        error_setg(errp, "backend driver with id %s could not be found",
> +                   s->backend);
>           return;
>       }
>
> @@ -1069,8 +1069,8 @@ static void tpm_tis_realizefn(DeviceState *dev, Error 
> **errp)
>       }
>
>       if (s->irq_num > 15) {
> -        error_setg(errp, "tpm_tis: IRQ %d for TPM TIS is outside valid range "
> -                   "of 0 to 15", s->irq_num);
> +        error_setg(errp, "IRQ %d is outside valid range of 0 to 15",
> +                   s->irq_num);
>           return;
>       }