[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 5/6] hw/i386: deprecate the pc-0.10 and pc-0
From: |
Alexey Kardashevskiy |
Subject: |
Re: [Qemu-devel] [RFC PATCH 5/6] hw/i386: deprecate the pc-0.10 and pc-0.11 machines |
Date: |
Wed, 8 Nov 2017 13:48:09 +1100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 08/11/17 13:28, Philippe Mathieu-Daudé wrote:
> Both are deprecated since 2.9.0
May be so but I could not find where this happened in git history:
[vpl1 qemu]$ git log -n1 --grep 'pc-0.10'
f6d5a0bad2 2 years, 5 months ago Eduardo Habkost piix: Define PC_COMPAT_0_10
Having some pointers in the commit log would be helpful imho, like [2/6].
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/i386/pc_piix.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> index f79d5cb694..c462b702ff 100644
> --- a/hw/i386/pc_piix.c
> +++ b/hw/i386/pc_piix.c
> @@ -941,6 +941,7 @@ static void pc_i440fx_0_11_machine_options(MachineClass
> *m)
> pc_i440fx_0_12_machine_options(m);
> m->hw_version = "0.11";
> SET_MACHINE_COMPAT(m, PC_COMPAT_0_11);
> + m->deprecated_reason = "Too old";
> }
>
> DEFINE_I440FX_MACHINE(v0_11, "pc-0.11", pc_compat_0_13,
> @@ -976,6 +977,7 @@ static void pc_i440fx_0_10_machine_options(MachineClass
> *m)
> pc_i440fx_0_11_machine_options(m);
> m->hw_version = "0.10";
> SET_MACHINE_COMPAT(m, PC_COMPAT_0_10);
> + m->deprecated_reason = "Too old";
> }
>
> DEFINE_I440FX_MACHINE(v0_10, "pc-0.10", pc_compat_0_13,
>
--
Alexey
- [Qemu-devel] [RFC PATCH 0/6] generic way to deprecate machines, Philippe Mathieu-Daudé, 2017/11/07
- [Qemu-devel] [RFC PATCH 1/6] machine: add a deprecated_reason property, Philippe Mathieu-Daudé, 2017/11/07
- [Qemu-devel] [RFC PATCH 2/6] hw/arm: deprecate the EP108 board, Philippe Mathieu-Daudé, 2017/11/07
- [Qemu-devel] [RFC PATCH 3/6] hw/arm: deprecate the Gumstix boards, Philippe Mathieu-Daudé, 2017/11/07
- [Qemu-devel] [RFC PATCH 4/6] hw/ppc: deprecate the PReP machine, Philippe Mathieu-Daudé, 2017/11/07
- [Qemu-devel] [RFC PATCH 5/6] hw/i386: deprecate the pc-0.10 and pc-0.11 machines, Philippe Mathieu-Daudé, 2017/11/07
- Re: [Qemu-devel] [RFC PATCH 5/6] hw/i386: deprecate the pc-0.10 and pc-0.11 machines,
Alexey Kardashevskiy <=
- Re: [Qemu-devel] [RFC PATCH 5/6] hw/i386: deprecate the pc-0.10 and pc-0.11 machines, Daniel P. Berrange, 2017/11/08
- Re: [Qemu-devel] [RFC PATCH 5/6] hw/i386: deprecate the pc-0.10 and pc-0.11 machines, Thomas Huth, 2017/11/08
[Qemu-devel] [RFC PATCH 6/6] hw/i386: deprecate the "isapc" machine, Philippe Mathieu-Daudé, 2017/11/07