Re: [Qemu-devel] i440/piix and dynamic sysbus check

[Marcel Apfelbaum]

On 07/11/2017 18:40, Marc-André Lureau wrote:
> Hi,
>
> I am working on a TPM CRB device (last sent version:
> https://lists.gnu.org/archive/html/qemu-devel/2017-10/msg02014.html).
> It's a sysbus device, and when starting qemu with i440, I get "Option
> '-device tpm-crb' cannot be handled by this machine".
>
> The check comes from machine_init_notify(), checking that the machine
> has_dynamic_sysbus.
>
>   Apparently, q35 supports it. But not i440. If I declare
> has_dynamic_sysbus in piix, the device works fine.
>
> Marcel, could we do something similar to piix to what you did for q35?:

Yes, as long as we check all sysbus devices that can't be created
with '-device' have their "cannot_be_insta...yet" flag set.

If Eduardo's series achieves the above is OK.

Thanks,
Marcel

> commit bf8d492405feaee2c1685b3b9d5e03228ed3e47f
> Author: Marcel Apfelbaum <address@hidden>
> Date:   Mon Jun 27 18:38:33 2016 +0300
>
>      q35: allow dynamic sysbus
>
> thanks