[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/5] iotests: Add missing 'blkdebug::' in 040
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/5] iotests: Add missing 'blkdebug::' in 040 |
Date: |
Thu, 9 Nov 2017 08:04:45 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 11/08/2017 07:38 PM, Max Reitz wrote:
> 040 tries to invoke pause_drive() on a drive that does not use blkdebug.
> Good idea, but let's use blkdebug to make it actually work.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> tests/qemu-iotests/040 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Eric Blake <address@hidden>
> diff --git a/tests/qemu-iotests/040 b/tests/qemu-iotests/040
> index c284d08796..90b5b4f2ad 100755
> --- a/tests/qemu-iotests/040
> +++ b/tests/qemu-iotests/040
> @@ -289,7 +289,7 @@ class TestSetSpeed(ImageCommitTestCase):
> qemu_img('create', '-f', iotests.imgfmt, '-o', 'backing_file=%s' %
> mid_img, test_img)
> qemu_io('-f', iotests.imgfmt, '-c', 'write -P 0x1 0 512', test_img)
> qemu_io('-f', iotests.imgfmt, '-c', 'write -P 0xef 524288 524288',
> mid_img)
> - self.vm = iotests.VM().add_drive(test_img)
> + self.vm = iotests.VM().add_drive('blkdebug::' + test_img)
> self.vm.launch()
>
> def tearDown(self):
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/5] iotests: Make some tests less flaky, Max Reitz, 2017/11/08
- [Qemu-devel] [PATCH 1/5] iotests: Make 030 less flaky, Max Reitz, 2017/11/08
- [Qemu-devel] [PATCH 2/5] iotests: Add missing 'blkdebug::' in 040, Max Reitz, 2017/11/08
- Re: [Qemu-devel] [PATCH 2/5] iotests: Add missing 'blkdebug::' in 040,
Eric Blake <=
- [Qemu-devel] [PATCH 3/5] iotests: Make 055 less flaky, Max Reitz, 2017/11/08
- [Qemu-devel] [PATCH 4/5] iotests: Make 083 less flaky, Max Reitz, 2017/11/08
- [Qemu-devel] [PATCH 5/5] iotests: Make 136 less flaky, Max Reitz, 2017/11/08
- Re: [Qemu-devel] [Qemu-block] [PATCH 0/5] iotests: Make some tests less flaky, Stefan Hajnoczi, 2017/11/09