[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/7] nbd-client: Fix error message typos
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/7] nbd-client: Fix error message typos |
Date: |
Thu, 9 Nov 2017 08:43:11 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 11/09/2017 02:58 AM, Vladimir Sementsov-Ogievskiy wrote:
> 09.11.2017 00:56, Eric Blake wrote:
>> Provide missing spaces that are required when using string
>> concatenation to break error messages across source lines.
>>
>> Signed-off-by: Eric Blake <address@hidden>
>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
>
>> @@ -408,7 +408,7 @@ static coroutine_fn int nbd_co_do_receive_one_chunk(
>> if (chunk->type == NBD_REPLY_TYPE_NONE) {
>> if (!(chunk->flags & NBD_REPLY_FLAG_DONE)) {
>> error_setg(errp, "Protocol error: NBD_REPLY_TYPE_NONE
>> chunk without"
>> - "NBD_REPLY_FLAG_DONE flag set");
>> + " NBD_REPLY_FLAG_DONE flag set");
>
> I think it's better not to change indentation here, as it is done so in
> other places.
> You don't like this way of indenting splitted strings?
s/splitted/split/ (one of those weird irregular English verbs)
I just did what emacs recommended when I hit TAB. Your indentation
style also works in isolation, even if it isn't the default that emacs
tries to give me. I could avoid the churn on this patch, but then my
addition in 6/7 looks inconsistent compared to this one, so I'll
probably just leave the indentation change in place.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 0/7] various NBD fixes for 2.11, Eric Blake, 2017/11/08
- [Qemu-devel] [PATCH v2 1/7] nbd-client: Fix error message typos, Eric Blake, 2017/11/08
- [Qemu-devel] [PATCH v2 3/7] nbd/client: Nicer trace of structured reply, Eric Blake, 2017/11/08
- [Qemu-devel] [PATCH v2 2/7] nbd-client: Refuse read-only client with BDRV_O_RDWR, Eric Blake, 2017/11/08
- [Qemu-devel] [PATCH v2 4/7] nbd: Fix struct name for structured reads, Eric Blake, 2017/11/08
- [Qemu-devel] [PATCH v2 5/7] nbd-client: Short-circuit 0-length operations, Eric Blake, 2017/11/08