[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V5] hw/pcie-pci-bridge: restrict to X86 and ARM
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH V5] hw/pcie-pci-bridge: restrict to X86 and ARM |
Date: |
Thu, 9 Nov 2017 13:43:06 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
Hi Marcel,
Cc'ing Paul and Yongbok Since I'm not sure their Boston board could also
use it.
On 11/09/2017 12:46 PM, Marcel Apfelbaum wrote:
> The PCIE-PCI bridge is specific to "pure" PCIe systems
> (on QEMU we have X86 and ARM), it does not make sense to
> have it in other archs.
>
> Reported-by: Thomas Huth <address@hidden>
> Signed-off-by: Marcel Apfelbaum <address@hidden>
> ---
>
> V4 -> V5
> - Since all other tries failed, conditioned the
> device on the PCIe Root Port.
>
> V3 -> V4:
> - Move the config line to pci.mak (Thomas)
>
> V2 -> V3:
> - Another tweak in subject s/if/it (Cornelia)
>
> V1 -> V2:
> Addressed Thomas and Cornelia comments:
> - Conditioned the pcie-pci-bridge compilation on
> the PCIe Root CONFIG_PCIE_PORT
> - Tweaked subject PCI -> PCIe
>
> Thanks,
> Marcel
>
>
> hw/pci-bridge/Makefile.objs | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/pci-bridge/Makefile.objs b/hw/pci-bridge/Makefile.objs
> index 666db37da2..1b05023662 100644
> --- a/hw/pci-bridge/Makefile.objs
> +++ b/hw/pci-bridge/Makefile.objs
> @@ -1,5 +1,5 @@
> -common-obj-y += pci_bridge_dev.o pcie_pci_bridge.o
> -common-obj-$(CONFIG_PCIE_PORT) += pcie_root_port.o gen_pcie_root_port.o
> +common-obj-y += pci_bridge_dev.o
> +common-obj-$(CONFIG_PCIE_PORT) += pcie_root_port.o gen_pcie_root_port.o
> pcie_pci_bridge.o
KISS :)
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
> common-obj-$(CONFIG_PXB) += pci_expander_bridge.o
> common-obj-$(CONFIG_XIO3130) += xio3130_upstream.o xio3130_downstream.o
> common-obj-$(CONFIG_IOH3420) += ioh3420.o
>