[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] fix scripts/update-linux-headers.sh here docume
From: |
Roman Kagan |
Subject: |
Re: [Qemu-devel] [PATCH] fix scripts/update-linux-headers.sh here document |
Date: |
Fri, 10 Nov 2017 19:14:16 +0300 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Fri, Nov 10, 2017 at 10:03:54AM +0100, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> scripts/update-linux-headers.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh
> index 8b847e279b..e2b159aa3d 100755
> --- a/scripts/update-linux-headers.sh
> +++ b/scripts/update-linux-headers.sh
> @@ -108,7 +108,7 @@ for arch in $ARCHLIST; do
> if [ $arch = x86 ]; then
> cat <<-EOF >"$output/include/standard-headers/asm-x86/hyperv.h"
> /* this is a temporary placeholder until kvm_para.h stops including
> it */
> - EOF
> +EOF
> cp "$tmpdir/include/asm/unistd_32.h" "$output/linux-headers/asm-x86/"
> cp "$tmpdir/include/asm/unistd_x32.h"
> "$output/linux-headers/asm-x86/"
> cp "$tmpdir/include/asm/unistd_64.h" "$output/linux-headers/asm-x86/"
Ugh, indeed, the minus sign after << causes the shell to strip only
preceding tabs, not spaces. Apparently I expanded the tabs after I
tested the script to work...
Fixes: 40bf8e9aede0f9105a9e1e4aaf17b20aaa55f9a0
Reviewed-by: Roman Kagan <address@hidden>
Thanks,
Roman.