[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.11 1/5] qcow2: check_errors are fatal
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH for-2.11 1/5] qcow2: check_errors are fatal |
Date: |
Fri, 10 Nov 2017 14:55:07 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 11/10/2017 02:31 PM, Max Reitz wrote:
> When trying to repair a dirty image, qcow2_check() may apparently
> succeed (no really fatal error occurred that would prevent the check
> from continuing), but if check_errors in the result object is non-zero,
> we cannot trust the image to be usable.
>
> Reported-by: R. Nageswara Sastry <address@hidden>
> Buglink: https://bugs.launchpad.net/qemu/+bug/1728639
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block/qcow2.c | 5 ++++-
> tests/qemu-iotests/060 | 20 ++++++++++++++++++++
> tests/qemu-iotests/060.out | 23 +++++++++++++++++++++++
> 3 files changed, 47 insertions(+), 1 deletion(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature