[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 8/8] sdl2: Ignore UI hotkeys after a focus chang
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 8/8] sdl2: Ignore UI hotkeys after a focus change when GUI modifier is held |
Date: |
Mon, 13 Nov 2017 14:29:46 +0100 |
User-agent: |
NeoMutt/20171027 |
Hi,
> if (!gui_grab && (qemu_input_is_absolute() || absolute_enabled)) {
> absolute_mouse_grab(scon);
> }
Can you please add a comment here describing why this is done?
>From the code alone it isn't obvious that this is a workaround
for a SDL bug.
> + scon->ignore_hotkeys = get_mod_state();
> break;
cheers,
Gerd
- Re: [Qemu-devel] [PATCH 1/8] sdl2: Fix broken display updating after the window is hidden, (continued)
- Re: [Qemu-devel] [PATCH 1/8] sdl2: Fix broken display updating after the window is hidden, Max Reitz, 2017/11/13
- Re: [Qemu-devel] [PATCH 1/8] sdl2: Fix broken display updating after the window is hidden, Gerd Hoffmann, 2017/11/14
- Re: [Qemu-devel] [PATCH 1/8] sdl2: Fix broken display updating after the window is hidden, Max Reitz, 2017/11/14
- Re: [Qemu-devel] [PATCH 1/8] sdl2: Fix broken display updating after the window is hidden, Gerd Hoffmann, 2017/11/14
- [Qemu-devel] [PATCH 3/8] sdl2: Use the same pointer show/hide logic for absolute and relative mode, Jindrich Makovicka, 2017/11/12
- [Qemu-devel] [PATCH 6/8] sdl2: Fix dead keyboard after fullsceen, Jindrich Makovicka, 2017/11/12
- [Qemu-devel] [PATCH 7/8] sdl2: Do not leave grab when fullscreen, Jindrich Makovicka, 2017/11/12
- [Qemu-devel] [PATCH 8/8] sdl2: Ignore UI hotkeys after a focus change when GUI modifier is held, Jindrich Makovicka, 2017/11/12
- Re: [Qemu-devel] [PATCH 8/8] sdl2: Ignore UI hotkeys after a focus change when GUI modifier is held,
Gerd Hoffmann <=
- Re: [Qemu-devel] [PATCH v3] SDL2 various fixes, Gerd Hoffmann, 2017/11/13
- Re: [Qemu-devel] [PATCH v3] SDL2 various fixes, Eric Blake, 2017/11/13