[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v10 4/8] qemu.py: always cleanup on shutdown()
From: |
Amador Pahim |
Subject: |
[Qemu-devel] [PATCH v10 4/8] qemu.py: always cleanup on shutdown() |
Date: |
Mon, 13 Nov 2017 23:23:54 +0100 |
Currently we only cleanup on shutdown() if the VM is running.
To make sure we will always cleanup, this patch makes the
self._load_io_log() and the self._post_shutdown() to
always be called on shutdown(), regardless the VM running state.
Reviewed-by: Fam Zheng <address@hidden>
Signed-off-by: Amador Pahim <address@hidden>
---
scripts/qemu.py | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/scripts/qemu.py b/scripts/qemu.py
index 813930301c..93f08129ad 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
@@ -162,8 +162,9 @@ class QEMUMachine(object):
return self._popen.pid
def _load_io_log(self):
- with open(self._qemu_log_path, "r") as iolog:
- self._iolog = iolog.read()
+ if self._qemu_log_path is not None:
+ with open(self._qemu_log_path, "r") as iolog:
+ self._iolog = iolog.read()
def _base_args(self):
if isinstance(self._monitor_address, tuple):
@@ -254,8 +255,8 @@ class QEMUMachine(object):
self._popen.kill()
self._popen.wait()
- self._load_io_log()
- self._post_shutdown()
+ self._load_io_log()
+ self._post_shutdown()
exitcode = self.exitcode()
if exitcode is not None and exitcode < 0:
--
2.13.6
- [Qemu-devel] [PATCH v10 0/8] scripts/qemu.py fixes and cleanups, Amador Pahim, 2017/11/13
- [Qemu-devel] [PATCH v10 1/8] qemu.py: remove unused import, Amador Pahim, 2017/11/13
- [Qemu-devel] [PATCH v10 2/8] qemu.py: better control of created files, Amador Pahim, 2017/11/13
- [Qemu-devel] [PATCH v10 3/8] qemu.py: refactor launch(), Amador Pahim, 2017/11/13
- [Qemu-devel] [PATCH v10 4/8] qemu.py: always cleanup on shutdown(),
Amador Pahim <=
- [Qemu-devel] [PATCH v10 5/8] qemu.py: use poll() instead of 'returncode', Amador Pahim, 2017/11/13
- [Qemu-devel] [PATCH v10 6/8] qemu.py: cleanup redundant calls in launch(), Amador Pahim, 2017/11/13
- [Qemu-devel] [PATCH v10 7/8] qemu.py: launch vm only if it's not running, Amador Pahim, 2017/11/13
- [Qemu-devel] [PATCH v10 8/8] qemu.py: don't launch again before shutdown(), Amador Pahim, 2017/11/13
- Re: [Qemu-devel] [PATCH v10 0/8] scripts/qemu.py fixes and cleanups, no-reply, 2017/11/13
- Re: [Qemu-devel] [PATCH v10 0/8] scripts/qemu.py fixes and cleanups, Markus Armbruster, 2017/11/14