[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v10 5/8] qemu.py: use poll() instead of 'returncode'
From: |
Amador Pahim |
Subject: |
[Qemu-devel] [PATCH v10 5/8] qemu.py: use poll() instead of 'returncode' |
Date: |
Mon, 13 Nov 2017 23:23:55 +0100 |
The 'returncode' Popen attribute is not guaranteed to be updated. It
actually depends on a call to either poll(), wait() or communicate().
On the other hand, poll() will: "Check if child process has terminated.
Set and return returncode attribute."
Let's use the poll() to check whether the process is running and to get
the updated process exit code, when the process is finished.
Reviewed-by: Fam Zheng <address@hidden>
Signed-off-by: Amador Pahim <address@hidden>
---
scripts/qemu.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/qemu.py b/scripts/qemu.py
index 93f08129ad..7224f88526 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
@@ -149,12 +149,12 @@ class QEMUMachine(object):
raise
def is_running(self):
- return self._popen is not None and self._popen.returncode is None
+ return self._popen is not None and self._popen.poll() is None
def exitcode(self):
if self._popen is None:
return None
- return self._popen.returncode
+ return self._popen.poll()
def get_pid(self):
if not self.is_running():
--
2.13.6
- [Qemu-devel] [PATCH v10 0/8] scripts/qemu.py fixes and cleanups, Amador Pahim, 2017/11/13
- [Qemu-devel] [PATCH v10 1/8] qemu.py: remove unused import, Amador Pahim, 2017/11/13
- [Qemu-devel] [PATCH v10 2/8] qemu.py: better control of created files, Amador Pahim, 2017/11/13
- [Qemu-devel] [PATCH v10 3/8] qemu.py: refactor launch(), Amador Pahim, 2017/11/13
- [Qemu-devel] [PATCH v10 4/8] qemu.py: always cleanup on shutdown(), Amador Pahim, 2017/11/13
- [Qemu-devel] [PATCH v10 5/8] qemu.py: use poll() instead of 'returncode',
Amador Pahim <=
- [Qemu-devel] [PATCH v10 6/8] qemu.py: cleanup redundant calls in launch(), Amador Pahim, 2017/11/13
- [Qemu-devel] [PATCH v10 7/8] qemu.py: launch vm only if it's not running, Amador Pahim, 2017/11/13
- [Qemu-devel] [PATCH v10 8/8] qemu.py: don't launch again before shutdown(), Amador Pahim, 2017/11/13
- Re: [Qemu-devel] [PATCH v10 0/8] scripts/qemu.py fixes and cleanups, no-reply, 2017/11/13
- Re: [Qemu-devel] [PATCH v10 0/8] scripts/qemu.py fixes and cleanups, Markus Armbruster, 2017/11/14