[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v2 05/26] replay: fixed replay_enable_events
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC PATCH v2 05/26] replay: fixed replay_enable_events |
Date: |
Tue, 14 Nov 2017 14:34:37 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 14/11/2017 09:17, Pavel Dovgalyuk wrote:
> This patch fixes assignment to internal events_enabled variable.
> Now it is set only in record/replay mode. This affects the behavior
> of the external functions that check this flag.
>
> Signed-off-by: Pavel Dovgalyuk <address@hidden>
>
> ---
> replay/replay-events.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/replay/replay-events.c b/replay/replay-events.c
> index 768b505..e858254 100644
> --- a/replay/replay-events.c
> +++ b/replay/replay-events.c
> @@ -67,7 +67,9 @@ static void replay_run_event(Event *event)
>
> void replay_enable_events(void)
> {
> - events_enabled = true;
> + if (replay_mode != REPLAY_MODE_NONE) {
> + events_enabled = true;
> + }
> }
>
> bool replay_has_events(void)
> @@ -141,7 +143,7 @@ void replay_add_event(ReplayAsyncEventKind event_kind,
>
> void replay_bh_schedule_event(QEMUBH *bh)
> {
> - if (replay_mode != REPLAY_MODE_NONE && events_enabled) {
> + if (events_enabled) {
> uint64_t id = replay_get_current_step();
> replay_add_event(REPLAY_ASYNC_EVENT_BH, bh, NULL, id);
> } else {
> @@ -161,7 +163,7 @@ void replay_add_input_sync_event(void)
>
> void replay_block_event(QEMUBH *bh, uint64_t id)
> {
> - if (replay_mode != REPLAY_MODE_NONE && events_enabled) {
> + if (events_enabled) {
> replay_add_event(REPLAY_ASYNC_EVENT_BLOCK, bh, NULL, id);
> } else {
> qemu_bh_schedule(bh);
>
Acked-by: Paolo Bonzini <address@hidden>
- [Qemu-devel] [RFC PATCH v2 00/26] replay additions, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 00/26] replay additions, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 01/26] block: implement bdrv_snapshot_goto for blkreplay, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 02/26] blkreplay: create temporary overlay for underlaying devices, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 03/26] replay: disable default snapshot for record/replay, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 04/26] replay: fix processing async events, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 05/26] replay: fixed replay_enable_events, Pavel Dovgalyuk, 2017/11/14
- Re: [Qemu-devel] [RFC PATCH v2 05/26] replay: fixed replay_enable_events,
Paolo Bonzini <=
- [Qemu-devel] [RFC PATCH v2 06/26] replay: fix save/load vm for non-empty queue, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 07/26] replay: added replay log format description, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 08/26] replay: make safe vmstop at record/replay, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 09/26] replay: save prior value of the host clock, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 10/26] icount: fixed saving/restoring of icount warp timers, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 11/26] target/arm/arm-powertctl: drop BQL assertions, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 12/26] cpus: push BQL lock to qemu_*_wait_io_event, Pavel Dovgalyuk, 2017/11/14