[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v2 21/26] replay: check return values of fwr
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC PATCH v2 21/26] replay: check return values of fwrite |
Date: |
Tue, 14 Nov 2017 14:37:36 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 14/11/2017 09:18, Pavel Dovgalyuk wrote:
> This patch adds error reporting when fwrite cannot completely
> save the buffer to the file.
>
> Signed-off-by: Pavel Dovgalyuk <address@hidden>
>
> ---
> replay/replay-internal.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/replay/replay-internal.c b/replay/replay-internal.c
> index a1a7686..1888400 100644
> --- a/replay/replay-internal.c
> +++ b/replay/replay-internal.c
> @@ -62,7 +62,9 @@ void replay_put_array(const uint8_t *buf, size_t size)
> {
> if (replay_file) {
> replay_put_dword(size);
> - fwrite(buf, 1, size, replay_file);
> + if (fwrite(buf, 1, size, replay_file) != size) {
> + error_report("replay write error");
> + }
> }
> }
>
>
Should the error be printed only once? In addition, putc is not tested
in the same way.
Paolo
- [Qemu-devel] [RFC PATCH v2 15/26] replay/replay-internal.c: track holding of replay_lock, (continued)
- [Qemu-devel] [RFC PATCH v2 15/26] replay/replay-internal.c: track holding of replay_lock, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 16/26] replay: make locking visible outside replay code, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 17/26] replay: push replay_mutex_lock up the call tree, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 18/26] cpu-exec: don't overwrite exception_index, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 19/26] cpu-exec: reset exit flag before calling cpu_exec_nocache, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 20/26] replay: don't destroy mutex at exit, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 21/26] replay: check return values of fwrite, Pavel Dovgalyuk, 2017/11/14
- Re: [Qemu-devel] [RFC PATCH v2 21/26] replay: check return values of fwrite,
Paolo Bonzini <=
- [Qemu-devel] [RFC PATCH v2 22/26] scripts/qemu-gdb: add simple tcg lock status helper, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 23/26] util/qemu-thread-*: add qemu_lock, locked and unlock trace events, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 24/26] scripts/analyse-locks-simpletrace.py: script to analyse lock times, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 25/26] scripts/replay-dump.py: replay log dumper, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 26/26] scripts/qemu-gdb/timers.py: new helper to dump timer state, Pavel Dovgalyuk, 2017/11/14
- Re: [Qemu-devel] [RFC PATCH v2 00/26] replay additions, no-reply, 2017/11/14
- Re: [Qemu-devel] [RFC PATCH v2 00/26] replay additions, no-reply, 2017/11/14