Re: [Qemu-devel] Command-line option to change ungrab key(s)

[Gerd Hoffmann]

  Hi,

> > Certainly not this way.
> 
> Did you have an idea on how something like this should look like? This
> feature would only change the old mouse ungrab keys to a
> user-specified one. So the basic algorithm would be change the text
> that displays at the top of the QEMU window to say (Press <user
> specified key(s)> to release mouse.

That is the easy part ;)

> Then tell the code that looks for
> the ungrab keys which keys to look out for.

Here it becomes more difficuilt.

> >  The display configuration we have right now is pretty messy
> >  already.  I want clean this up (draft patch series at
> >  https://www.kraxel.org/cgit/qemu/log/?h=lupin/display-cmdline), and
> >  this should be done before adding new stuff.
> 
> My original idea was to make a patch that would only change the
> cocoa.m file. I'm thinking you want this code to be elsewhere.
> Somewhere where other UI code like GTK would be able to use. Is that
> what you prefer?

Well, at least the command line parsing part should be in common code,
yes.  Detecting and handling the hotkeys will most likely stay in
UI-specific code.

> > Also when making this configurable it should be consistent across
> > all user interfaces we have, which surely is a non-trivial amount of
> > work.
> 
> I know Cocoa but my lack of GTK experience would not permit me to make
> a patch for that UI code. When you are done with your display
> configuration work, would there even be a need to patch the Cocoa/GTK
> code? I'm under the impression you are trying to consolidate some of
> the UI code under one file.

No.  But standardize the interface between UIs and qemu, which will not
only standardize the configuration, but should also make it easier to
build the UIs as modules.

cheers,
  Gerd