Re: [Qemu-devel] [PATCH] tcg: Record code_gen_buffer address for user-only memory helpers

[Richard Henderson]

On 11/14/2017 05:09 PM, Alex Bennée wrote:
>> -    /* Now we have a real cpu fault.  Since this is the exact location of
>> -     * the exception, we must undo the adjustment done by cpu_restore_state
>> -     * for handling call return addresses.  */
>> -    cpu_restore_state(cpu, pc + GETPC_ADJ);
>> +    /* Now we have a real cpu fault.  */
>> +    cpu_restore_state(cpu, pc);
> 
> I can't help thinking when we get it wrong we should be doing something
> here, maybe a LOG_UNIMP? Otherwise we silently fail or at least the
> user-space falls off a cliff later.

Oh we silently get it wrong in so many ways.  E.g. zero callers of
cpu_restore_state_from_tb check its return status.  Anyway, I think this sort
of cleanup has to wait til next cycle.


r~