qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3] hw/arm/aspeed: Unlock SCU when running kerne


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v3] hw/arm/aspeed: Unlock SCU when running kernel
Date: Wed, 15 Nov 2017 11:56:41 +0000

On 15 November 2017 at 08:18, Cédric Le Goater <address@hidden> wrote:
> On 11/14/2017 01:20 PM, Joel Stanley wrote:
>> The ASPEED hardware contains a lock register for the SCU that disables
>> any writes to the SCU when it is locked. The machine comes up with the
>> lock enabled, but on all known hardware u-boot will unlock it and leave
>> it unlocked when loading the kernel.
>>
>> This means the kernel expects the SCU to be unlocked. When booting from
>> an emulated ROM the normal u-boot unlock path is executed. Things don't
>> go well when booting using the -kernel command line, as u-boot does not
>> run first.
>>
>> Change behaviour so that when a kernel is passed to the machine, set the
>> reset value of the SCU to be unlocked.
>>
>> Signed-off-by: Joel Stanley <address@hidden>
>
> Reviewed-by: Cédric Le Goater <address@hidden>

Thanks. Should this go into 2.11 ? It sounds like the kind of
bugfix that ought to...

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]