[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC v4 18/27] monitor: send event when request queue full
From: |
Peter Xu |
Subject: |
[Qemu-devel] [RFC v4 18/27] monitor: send event when request queue full |
Date: |
Thu, 16 Nov 2017 21:06:01 +0800 |
Set maximum QMP request queue length to 8. If queue full, instead of
queue the command, we directly return a "request-dropped" event, telling
client that specific command is dropped.
Note that this flow control mechanism is only valid if OOB is enabled.
If it's not, the effective queue length will always be 1, which strictly
follows original behavior of QMP command handling (which never drop
messages).
Signed-off-by: Peter Xu <address@hidden>
---
monitor.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/monitor.c b/monitor.c
index 0e2ff114cc..92e846e195 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4029,6 +4029,8 @@ static void monitor_qmp_bh_dispatcher(void *data)
}
}
+#define QMP_REQ_QUEUE_LEN_MAX (8)
+
static void handle_qmp_command(JSONMessageParser *parser, GQueue *tokens,
void *opaque)
{
@@ -4061,6 +4063,19 @@ static void handle_qmp_command(JSONMessageParser
*parser, GQueue *tokens,
req_obj->id = id;
req_obj->req = req;
+ if (qmp_oob_enabled(mon)) {
+ /* Drop the request if queue is full. */
+ if (mon->qmp.qmp_requests->length >= QMP_REQ_QUEUE_LEN_MAX) {
+ qapi_event_send_request_dropped(id,
+ REQUEST_DROP_REASON_QUEUE_FULL,
+ NULL);
+ qobject_decref(id);
+ qobject_decref(req);
+ g_free(req_obj);
+ return;
+ }
+ }
+
/*
* Put the request to the end of queue so that requests will be
* handled in time order. Ownership for req_obj, req, id,
--
2.13.6
- Re: [Qemu-devel] [RFC v4 09/27] monitor: create monitor dedicate iothread, (continued)
- [Qemu-devel] [RFC v4 11/27] qmp: introduce QMPCapability, Peter Xu, 2017/11/16
- [Qemu-devel] [RFC v4 13/27] qmp: introduce some capability helpers, Peter Xu, 2017/11/16
- [Qemu-devel] [RFC v4 12/27] qmp: negociate QMP capabilities, Peter Xu, 2017/11/16
- [Qemu-devel] [RFC v4 14/27] monitor: introduce monitor_qmp_respond(), Peter Xu, 2017/11/16
- [Qemu-devel] [RFC v4 15/27] monitor: let monitor_{suspend|resume} thread safe, Peter Xu, 2017/11/16
- [Qemu-devel] [RFC v4 16/27] monitor: separate QMP parser and dispatcher, Peter Xu, 2017/11/16
- [Qemu-devel] [RFC v4 17/27] qmp: add new event "request-dropped", Peter Xu, 2017/11/16
- [Qemu-devel] [RFC v4 18/27] monitor: send event when request queue full,
Peter Xu <=
- [Qemu-devel] [RFC v4 19/27] qapi: introduce new cmd option "allow-oob", Peter Xu, 2017/11/16
- [Qemu-devel] [RFC v4 20/27] qmp: support out-of-band (oob) execution, Peter Xu, 2017/11/16
- [Qemu-devel] [RFC v4 21/27] qmp: let migrate-incoming allow out-of-band, Peter Xu, 2017/11/16
- Re: [Qemu-devel] [RFC v4 21/27] qmp: let migrate-incoming allow out-of-band, Dr. David Alan Gilbert, 2017/11/24
- Re: [Qemu-devel] [RFC v4 21/27] qmp: let migrate-incoming allow out-of-band, Peter Xu, 2017/11/27
- Re: [Qemu-devel] [RFC v4 21/27] qmp: let migrate-incoming allow out-of-band, Dr. David Alan Gilbert, 2017/11/27
- Re: [Qemu-devel] [RFC v4 21/27] qmp: let migrate-incoming allow out-of-band, Peter Xu, 2017/11/27
- Re: [Qemu-devel] [RFC v4 21/27] qmp: let migrate-incoming allow out-of-band, Dr. David Alan Gilbert, 2017/11/27
- Re: [Qemu-devel] [RFC v4 21/27] qmp: let migrate-incoming allow out-of-band, Peter Xu, 2017/11/27
[Qemu-devel] [RFC v4 22/27] qmp: isolate responses into io thread, Peter Xu, 2017/11/16