[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/15] sun4u: move ISABus inside of EBusState
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 03/15] sun4u: move ISABus inside of EBusState |
Date: |
Sun, 19 Nov 2017 11:53:42 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 11/17/2017 10:42 AM, Mark Cave-Ayland wrote:
> Since the EBus is effectively a PCI-ISA bridge then the underlying ISA bus
> should be contained within the PCI bridge itself.
>
> Signed-off-by: Mark Cave-Ayland <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/sparc64/sun4u.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c
> index 394b7d6..63b4aaa 100644
> --- a/hw/sparc64/sun4u.c
> +++ b/hw/sparc64/sun4u.c
> @@ -84,6 +84,7 @@ typedef struct EbusState {
> /*< private >*/
> PCIDevice parent_obj;
>
> + ISABus *isa_bus;
> MemoryRegion bar0;
> MemoryRegion bar1;
> } EbusState;
> @@ -245,8 +246,10 @@ static void ebus_realize(PCIDevice *pci_dev, Error
> **errp)
> {
> EbusState *s = EBUS(pci_dev);
>
> - if (!isa_bus_new(DEVICE(pci_dev), get_system_memory(),
> - pci_address_space_io(pci_dev), errp)) {
> + s->isa_bus = isa_bus_new(DEVICE(pci_dev), get_system_memory(),
> + pci_address_space_io(pci_dev), errp);
> + if (!s->isa_bus) {
> + error_setg(errp, "unable to instantiate EBUS ISA bus");
> return;
> }
>
>
- Re: [Qemu-devel] [PATCH 01/15] apb: move QOM macros and typedefs from apb.c to apb.h, (continued)
- [Qemu-devel] [PATCH 06/15] apb: APB QOMify tidy-up, Mark Cave-Ayland, 2017/11/17
- [Qemu-devel] [PATCH 07/15] apb: return APBState from pci_apb_init() rather then PCIBus, Mark Cave-Ayland, 2017/11/17
- [Qemu-devel] [PATCH 08/15] apb: use gpios to wire up the apb device to the SPARC CPU IRQs, Mark Cave-Ayland, 2017/11/17
- [Qemu-devel] [PATCH 09/15] apb: move the two secondary PCI bridges objects into APBState, Mark Cave-Ayland, 2017/11/17
- [Qemu-devel] [PATCH 11/15] apb: split pci_pbm_map_irq() into separate functions for bus A and bus B, Mark Cave-Ayland, 2017/11/17