[Qemu-devel] "make -C roms lgplvgabios" broken

[Eduardo Habkost]

Hi,

It looks like "make -C roms lgplvgabios" is broken since 2014
(commit 7a4dfd1e "virtio-vga: add vgabios configuration"):

  [roms]$ make lgplvgabios
  make -C vgabios vgabios-stdvga.bin vgabios-cirrus.bin vgabios-vmware.bin 
vgabios-qxl.bin vgabios.bin vgabios-virtio.bin
  make[1]: Entering directory '/home/ehabkost/rh/proj/virt/qemu/roms/vgabios'
  gcc -o vbetables-gen vbetables-gen.c
  ./vbetables-gen > vbetables.h
  gcc -o biossums biossums.c
  gcc -E -P vgabios.c  -DVBE -DPCIBIOS -DPCI_VID=0x1234 -DPCI_DID=0x1111 
"-DVGABIOS_DATE=\"`date '+%d %b %Y'`\"" > _vgabios-stdvga_.c
  bcc -o vgabios-stdvga.s -C-c -D__i86__ -S -0 _vgabios-stdvga_.c
  sed -e 's/^\.text//' -e 's/^\.data//' vgabios-stdvga.s > _vgabios-stdvga_.s
  as86 _vgabios-stdvga_.s -b vgabios-stdvga.bin -u -w- -g -0 -j -O -l 
vgabios-stdvga.txt
  rm -f _vgabios-stdvga_.s _vgabios-stdvga_.c vgabios-stdvga.s
  mv vgabios-stdvga.bin VGABIOS-lgpl-latest.stdvga.bin
  ./biossums VGABIOS-lgpl-latest.stdvga.bin
  
  [...]
  
  Bios checksum at:   0x9DFF
  Current checksum:     0x00
  Calculated checksum:  0x6D  Setting checksum.
  ls -l VGABIOS-lgpl-latest.bin
  -rw-rw-r--. 1 ehabkost ehabkost 40448 nov 20 09:20 VGABIOS-lgpl-latest.bin
  gcc -E -P vgabios.c   "-DVGABIOS_DATE=\"`date '+%d %b %Y'`\"" > 
_vgabios-virtio_.c
  bcc -o vgabios-virtio.s -C-c -D__i86__ -S -0 _vgabios-virtio_.c
  sed -e 's/^\.text//' -e 's/^\.data//' vgabios-virtio.s > _vgabios-virtio_.s
  as86 _vgabios-virtio_.s -b vgabios-virtio.bin -u -w- -g -0 -j -O -l 
vgabios-virtio.txt
  rm -f _vgabios-virtio_.s _vgabios-virtio_.c vgabios-virtio.s
  mv vgabios-virtio.bin
  mv: missing destination file operand after 'vgabios-virtio.bin'
  Try 'mv --help' for more information.
  make[1]: *** [Makefile:82: vgabios-virtio.bin] Error 1
  make[1]: Leaving directory '/home/ehabkost/rh/proj/virt/qemu/roms/vgabios'
  make: *** [Makefile:104: build-lgplvgabios] Error 2
  [roms]$ 

Do we still care enough about lgplvgabios to try to fix that, or
should we just remove the lgplvgabios rules and the roms/vgabios
submodule?  The last commit in our vgabios.git submodule was 7
years ago.

Related to that, pc-bios/README seems to be outdated, as it says
the VGA BIOS come from lgplvgabios, which doesn't seem to be the
case anymore.

-- 
Eduardo