[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] build: disarm the TCG unit test trap
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2] build: disarm the TCG unit test trap |
Date: |
Tue, 21 Nov 2017 15:50:39 +0000 |
On 21 November 2017 at 14:25, Daniel P. Berrange <address@hidden> wrote:
> Developers sometimes mistakenly run 'make test' instead of 'make check'.
> 'make test' triggers the ancient, unmaintained tcg unit tests in
> tests/tcg/Makefile which have long since ceased compiling.
>
> Even if someone fixes the TCG tests, it makes little sense to put
> them in a 'make test' target, rather they should be 'make check-tcg',
> possibly wired up as a dependency of 'make check'.
>
> In the meantime, this patch disarms the 'make test' trap by simply
> deleting it so users get an immediate error. This should be enough
> for them to remember to type 'make check' instead (or 'make help'
> to learn). It also deletes 'make speed' which is another route
> into the tcg tests.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>
Applied to master, thanks (will be nice to stop having to
tell people about this one :-))
-- PMM