[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 2/6] migration: free addr in the same function th
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PATCH v2 2/6] migration: free addr in the same function that we created it |
Date: |
Wed, 22 Nov 2017 13:42:15 +0100 |
Otherwise, we can't use it after calling socket_start_incoming_migration
Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
---
migration/socket.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/migration/socket.c b/migration/socket.c
index dee869044a..3a8232dd2d 100644
--- a/migration/socket.c
+++ b/migration/socket.c
@@ -172,7 +172,6 @@ static void socket_start_incoming_migration(SocketAddress
*saddr,
if (qio_channel_socket_listen_sync(listen_ioc, saddr, errp) < 0) {
object_unref(OBJECT(listen_ioc));
- qapi_free_SocketAddress(saddr);
return;
}
@@ -181,7 +180,6 @@ static void socket_start_incoming_migration(SocketAddress
*saddr,
socket_accept_incoming_migration,
listen_ioc,
(GDestroyNotify)object_unref);
- qapi_free_SocketAddress(saddr);
}
void tcp_start_incoming_migration(const char *host_port, Error **errp)
@@ -191,6 +189,7 @@ void tcp_start_incoming_migration(const char *host_port,
Error **errp)
if (!err) {
socket_start_incoming_migration(saddr, &err);
}
+ qapi_free_SocketAddress(saddr);
error_propagate(errp, err);
}
@@ -198,4 +197,5 @@ void unix_start_incoming_migration(const char *path, Error
**errp)
{
SocketAddress *saddr = unix_build_address(path);
socket_start_incoming_migration(saddr, errp);
+ qapi_free_SocketAddress(saddr);
}
--
2.13.6
- [Qemu-devel] [PATCH v2 0/6] Improve info migrate output on destination, Juan Quintela, 2017/11/22
- [Qemu-devel] [PATCH v2 1/6] migration: print features as on off, Juan Quintela, 2017/11/22
- [Qemu-devel] [PATCH v2 3/6] migration: Create uri parameter, Juan Quintela, 2017/11/22
- [Qemu-devel] [PATCH v2 2/6] migration: free addr in the same function that we created it,
Juan Quintela <=
- [Qemu-devel] [PATCH v2 6/6] migration: Set the new port/address in the uri parameter, Juan Quintela, 2017/11/22
- [Qemu-devel] [PATCH v2 5/6] migration: make migrate uri parameter optional, Juan Quintela, 2017/11/22
- [Qemu-devel] [PATCH v2 4/6] migration: Now set the migration uri, Juan Quintela, 2017/11/22
- Re: [Qemu-devel] [PATCH v2 0/6] Improve info migrate output on destination, no-reply, 2017/11/22