|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH v1 07/12] target/arm: Decode aa32 armv8.1 two reg and a scalar |
Date: | Wed, 22 Nov 2017 14:12:14 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 11/13/2017 06:05 PM, Alex Bennée wrote: >> - default: /* 14 and 15 are RESERVED */ >> + default: >> return 1; > > I think this should now be g_assert_not_reached() as we decode the whole > op space. That said it's tricky to follow in the mega function that > extracts op with old-school shifts 5 different ways :-/ You're right. Thanks. r~
[Prev in Thread] | Current Thread | [Next in Thread] |