[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] s390x/migration: use zero flag parameter
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] s390x/migration: use zero flag parameter |
Date: |
Wed, 22 Nov 2017 15:49:19 +0100 |
On Wed, 22 Nov 2017 15:37:55 +0100
Thomas Huth <address@hidden> wrote:
> On 22.11.2017 15:26, Christian Borntraeger wrote:
> > valgrind pointed out that we call KVM_S390_GET_IRQ_STATE with an
> > undefined value for flags. Right now this is unused, but we
> > better play safe.
> > The same is true for SET_IRQ_STATE. While QEMU is now fixed in
> > that regard, we should make sure to not use the flag and pad
> > fields in the kernel. A corresponding kernel documentation patch
> > will be submitted later.
> >
> > Signed-off-by: Christian Borntraeger <address@hidden>
> > ---
> > target/s390x/kvm.c | 16 ++++++++--------
> > 1 file changed, 8 insertions(+), 8 deletions(-)
(...)
> Reviewed-by: Thomas Huth <address@hidden>
>
> IMHO that would still be fine for 2.11, too.
I can queue this if another fix comes along, but I'd not push it on its
own.
- [Qemu-devel] [PATCH 0/2] s390x fixes (post 2.11), Christian Borntraeger, 2017/11/22
- [Qemu-devel] [PATCH 1/2] s390x/migration: use zero flag parameter, Christian Borntraeger, 2017/11/22
- [Qemu-devel] [PATCH 2/2] pc-bios/s390-ccw: zero out bss section, Christian Borntraeger, 2017/11/22
- Re: [Qemu-devel] [PATCH 0/2] s390x fixes (post 2.11), Cornelia Huck, 2017/11/22
- Re: [Qemu-devel] [PATCH 0/2] s390x fixes (post 2.11), Cornelia Huck, 2017/11/22
- Re: [Qemu-devel] [PATCH 0/2] s390x fixes (post 2.11), no-reply, 2017/11/22