[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] pc-bios/s390-ccw: zero out bss section
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] pc-bios/s390-ccw: zero out bss section |
Date: |
Thu, 23 Nov 2017 08:32:26 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 11/22/2017 03:26 PM, Christian Borntraeger wrote:
> The QEMU ELF loader does not zero the bss segment.
> This resulted in several bugs, e.g. see
>
> commit 5d739a4787a5 (s390-ccw.img: Fix sporadic errors with ccw boot image -
> initialize css)
> commit 6a40fa2669d3 (s390-ccw.img: Initialize next_idx)
> commit 8775d91a0f42 (pc-bios/s390-ccw: Fix problem with invalid virtio-scsi
> LUN when rebooting)
>
> Lets fix this once and forever by letting the BIOS zero the bss itself.
>
> Suggested-by: Alexander Graf <address@hidden>
> Signed-off-by: Christian Borntraeger <address@hidden>
> ---
> pc-bios/s390-ccw/start.S | 30 +++++++++++++++++++++++++++---
> 1 file changed, 27 insertions(+), 3 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [PATCH 0/2] s390x fixes (post 2.11), Christian Borntraeger, 2017/11/22
- [Qemu-devel] [PATCH 1/2] s390x/migration: use zero flag parameter, Christian Borntraeger, 2017/11/22
- [Qemu-devel] [PATCH 2/2] pc-bios/s390-ccw: zero out bss section, Christian Borntraeger, 2017/11/22
- Re: [Qemu-devel] [PATCH 0/2] s390x fixes (post 2.11), Cornelia Huck, 2017/11/22
- Re: [Qemu-devel] [PATCH 0/2] s390x fixes (post 2.11), Cornelia Huck, 2017/11/22
- Re: [Qemu-devel] [PATCH 0/2] s390x fixes (post 2.11), no-reply, 2017/11/22