[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL for-2.11 0/1] qemu-ga patch queue for 2.11
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PULL for-2.11 0/1] qemu-ga patch queue for 2.11 |
Date: |
Mon, 20 Nov 2017 14:05:51 -0800 (PST) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PULL for-2.11 0/1] qemu-ga patch queue for 2.11
Type: series
Message-id: address@hidden
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
4dc0db9e07 qga: replace GetIfEntry with GetIfEntry2 for interface stats
=== OUTPUT BEGIN ===
Checking PATCH 1/1: qga: replace GetIfEntry with GetIfEntry2 for interface
stats...
ERROR: space prohibited between function name and open parenthesis '('
#26: FILE: qga/commands-win32.c:1173:
+typedef NETIOAPI_API (WINAPI *GetIfEntry2Func)(PMIB_IF_ROW2 Row);
ERROR: spaces required around that '*' (ctx:WxV)
#26: FILE: qga/commands-win32.c:1173:
+typedef NETIOAPI_API (WINAPI *GetIfEntry2Func)(PMIB_IF_ROW2 Row);
^
total: 2 errors, 0 warnings, 62 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden