Re: [Qemu-devel] [PATCH v5 0/4] ITS Reset

[Auger Eric]

Hi Peter,

On 24/11/17 15:20, Peter Maydell wrote:
> On 24 November 2017 at 14:18, Eric Auger <address@hidden> wrote:
>> At the moment the ITS is not properly reset. On System reset or
>> reboot, previous ITS register values and caches are left
>> unchanged. Some of the registers might point to some guest RAM
>> tables which are not valid anymore. This leads to state
>> inconsistencies that are detected by the kernel save/restore
>> code. And eventually this may cause qemu abort.
>>
>> This series adds vITS reset modality:
>> - the 2 first patches bring a minimalist reset through individual
>>   register writes. However, with kernel versions < 4.15, this reset
>>   is not complete (vITS caches are not voided).
>> - With kernel versions >= 4.15 we can rely on a new ITS KVM device
>>   reset IOTCL. The last 2 patches introduce the full reset.
>>
>> Tested with 4.11, 4.14 and 4.15 host kernels.
> 
> Thanks. My remaining question is: how important it is to
> put some of this into 2.11? We're getting quite close to
> the release now so I'm getting gradually more reluctant
> to put in changes.

I fully understand.

Anyway clean and comprehensive reset modality would require v4.15 + full
QEMU series (otherwise you get the scary error message even if full
reset can be achieved by individual register writes).

This means the migration of guests while they are booting will not be
functional in 2.11. However it should not abort QEMU as it did before,
with a kernel >= v4.14.

Thanks

Eric

> 
> thanks
> -- PMM
>