[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 05/45] windbg: added helper features
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v3 05/45] windbg: added helper features |
Date: |
Tue, 28 Nov 2017 08:34:16 +0000 |
On 28 November 2017 at 08:18, Ladi Prosek <address@hidden> wrote:
> On Tue, Nov 21, 2017 at 3:07 PM, Mihail Abakumov
> <address@hidden> wrote:
>> Added some helper features for windbgstub.
> --- a/include/exec/windbgstub-utils.h
> +++ b/include/exec/windbgstub-utils.h
> @@ -32,7 +32,7 @@
> #define FMT_ERR "Error:%d"
>
> #define UINT8_P(ptr) ((uint8_t *) (ptr))
> -#define UINT32_P(ptr) ((uint32_t *) (ptr))
> +#define UINT32_P(ptr) ((uint32_t *) (size_t) (ptr))
> #define PTR(var) UINT8_P(&var)
Hiding casts behind macros like this doesn't seem worthwhile
to me anyway -- all it's doing is obscuring what's going on.
And casting an arbitrary pointer to a uint32_t* is somewhat
alarming -- the alignment requirements may not be met.
Chances are high that code using that macro is not correct.
thanks
-- PMM
- [Qemu-devel] [PATCH v3 00/45] Windbg supporting, Mihail Abakumov, 2017/11/21
- [Qemu-devel] [PATCH v3 01/45] windbg: added empty windbgstub files, Mihail Abakumov, 2017/11/21
- [Qemu-devel] [PATCH v3 03/45] windbg: modified windbgkd.h, Mihail Abakumov, 2017/11/21
- [Qemu-devel] [PATCH v3 02/45] windbg: added windbg's KD header file, Mihail Abakumov, 2017/11/21
- [Qemu-devel] [PATCH v3 04/45] windbg: added '-windbg' option, Mihail Abakumov, 2017/11/21
- [Qemu-devel] [PATCH v3 05/45] windbg: added helper features, Mihail Abakumov, 2017/11/21
- [Qemu-devel] [PATCH v3 06/45] windbg: added WindbgState, Mihail Abakumov, 2017/11/21
- [Qemu-devel] [PATCH v3 07/45] windbg: added chardev, Mihail Abakumov, 2017/11/21
- [Qemu-devel] [PATCH v3 10/45] windbg: structures for parsing data stream, Mihail Abakumov, 2017/11/21
- [Qemu-devel] [PATCH v3 08/45] windbg: hook to wrmsr operation, Mihail Abakumov, 2017/11/21
- [Qemu-devel] [PATCH v3 09/45] windbg: handler of fs/gs register, Mihail Abakumov, 2017/11/21
- [Qemu-devel] [PATCH v3 11/45] windbg: parsing data stream, Mihail Abakumov, 2017/11/21
- [Qemu-devel] [PATCH v3 12/45] windbg: send data and control packets, Mihail Abakumov, 2017/11/21
- [Qemu-devel] [PATCH v3 14/45] windbg: init DBGKD_ANY_WAIT_STATE_CHANGE, Mihail Abakumov, 2017/11/21