Re: [Qemu-devel] [PATCH] vhost-user spec: Clarify policy on setting log_base

[Victor Kaplansky]

> > +Note that master is not expected to issue more than one
> > VHOST_USER_SET_LOG_BASE
> > +request before the rings are fully stopped by the master. Thus no
> > modifications
> > +to log_base address are allowed before the rings are restated and the
> > client
> > +can ignore all subsequent VHOST_USER_SET_LOG_BASE requests after the
> > log_base
> > +address has been established.
> > +
> 
> Do we actually issue VHOST_USER_SET_LOG_BASE when ring is started?

Sorry, missed this question in the previous answer.
Yes, actually qemu issues set_log_base() only in the process of migration,
and before that rings are enabled and actively updated.

> 
> Can we put it simpler:
> 
>       master must not send VHOST_USER_SET_LOG_BASE when ring
>       is started and logging of used ring writes is started.
> 
> ?