Re: [Qemu-devel] [PATCH-2.12 v1 3/3] xilinx_spips: Use memset instead of a for loop to zero registers

[KONRAD Frederic]

On 11/28/2017 11:31 PM, Alistair Francis wrote:
> Use memset() instead of a for loop to zero all of the registers.
>
> Signed-off-by: Alistair Francis <address@hidden>
> ---
>
>   hw/ssi/xilinx_spips.c | 11 +++--------
>   1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c
> index 1a37f9c7f5..82436e2f69 100644
> --- a/hw/ssi/xilinx_spips.c
> +++ b/hw/ssi/xilinx_spips.c
> @@ -330,10 +330,7 @@ static void xilinx_spips_reset(DeviceState *d)
>   {
>       XilinxSPIPS *s = XILINX_SPIPS(d);
>   
> -    int i;
> -    for (i = 0; i < XLNX_SPIPS_R_MAX; i++) {
> -        s->regs[i] = 0;
> -    }
> +    memset(s->regs, 0, sizeof(s->regs));
>   
>       fifo8_reset(&s->rx_fifo);
>       fifo8_reset(&s->rx_fifo);
> @@ -358,13 +355,11 @@ static void xilinx_spips_reset(DeviceState *d)
>   static void xlnx_zynqmp_qspips_reset(DeviceState *d)
>   {
>       XlnxZynqMPQSPIPS *s = XLNX_ZYNQMP_QSPIPS(d);
> -    int i;
>   
>       xilinx_spips_reset(d);
>   
> -    for (i = 0; i < XLNX_ZYNQMP_SPIPS_R_MAX; i++) {
> -        s->regs[i] = 0;
> -    }
> +    memset(s->regs, 0, sizeof(s->regs));
> +
>       fifo8_reset(&s->rx_fifo_g);
>       fifo8_reset(&s->rx_fifo_g);
>       fifo32_reset(&s->fifo_g);

Reviewed-by: KONRAD Frederic <address@hidden>