qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] firmware: Use PTR_ERR_OR_ZERO()


From: Gabriel L. Somlo
Subject: Re: [Qemu-devel] [PATCH] firmware: Use PTR_ERR_OR_ZERO()
Date: Wed, 29 Nov 2017 10:01:05 -0500
User-agent: Mutt/1.9.1 (2017-09-22)

Acked-by: Gabriel Somlo <address@hidden>

On Tue, Nov 28, 2017 at 10:40:27PM +0100, Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> drivers/firmware/efi/efi.c:610:8-14: WARNING: PTR_ERR_OR_ZERO can be used
> 
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> 
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
> 
> Signed-off-by: Vasyl Gomonovych <address@hidden>
> ---
>  drivers/firmware/qemu_fw_cfg.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
> index 5cfe39f7a45f..18489b6a696d 100644
> --- a/drivers/firmware/qemu_fw_cfg.c
> +++ b/drivers/firmware/qemu_fw_cfg.c
> @@ -693,10 +693,8 @@ static int fw_cfg_cmdline_set(const char *arg, const 
> struct kernel_param *kp)
>        */
>       fw_cfg_cmdline_dev = platform_device_register_simple("fw_cfg",
>                                       PLATFORM_DEVID_NONE, res, processed);
> -     if (IS_ERR(fw_cfg_cmdline_dev))
> -             return PTR_ERR(fw_cfg_cmdline_dev);
>  
> -     return 0;
> +     return PTR_ERR_OR_ZERO(fw_cfg_cmdline_dev);
>  }
>  
>  static int fw_cfg_cmdline_get(char *buf, const struct kernel_param *kp)
> -- 
> 1.9.1
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]