[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 for-2.12 01/15] s390x/tcg: introduce and use
From: |
David Hildenbrand |
Subject: |
Re: [Qemu-devel] [PATCH v1 for-2.12 01/15] s390x/tcg: introduce and use program_interrupt_ra() |
Date: |
Wed, 29 Nov 2017 16:13:28 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 29.11.2017 15:55, Cornelia Huck wrote:
> On Tue, 28 Nov 2017 21:33:11 +0100
> David Hildenbrand <address@hidden> wrote:
>
>> Allows to easily convert more callers of program_interrupt() and to
>> easily introduce new exceptions without forgetting about the cpu state
>> reset.
>>
>> Use program_interrupt_ra() in places where we already had the same
>> pattern.
>>
>> Signed-off-by: David Hildenbrand <address@hidden>
>> ---
>> target/s390x/cpu.h | 2 ++
>> target/s390x/crypto_helper.c | 7 ++-----
>> target/s390x/excp_helper.c | 5 +----
>> target/s390x/interrupt.c | 13 +++++++++++++
>> target/s390x/mem_helper.c | 35 +++++++++++------------------------
>> target/s390x/misc_helper.c | 3 +--
>> 6 files changed, 30 insertions(+), 35 deletions(-)
>
>> diff --git a/target/s390x/interrupt.c b/target/s390x/interrupt.c
>> index ce6177c141..6ce06bb549 100644
>> --- a/target/s390x/interrupt.c
>> +++ b/target/s390x/interrupt.c
>> @@ -53,6 +53,19 @@ void program_interrupt(CPUS390XState *env, uint32_t code,
>> int ilen)
>> }
>> }
>>
>> +void program_interrupt_ra(CPUS390XState *env, uint32_t code, int ilen,
>> + uintptr_t ra)
>> +{
>> + S390CPU *cpu = s390_env_get_cpu(env);
>
> Move this under the if?
>
Indeed, thanks.
--
Thanks,
David / dhildenb
- [Qemu-devel] [PATCH v1 for-2.12 00/15] s390x/tcg: cleanup and fix program interrupts, David Hildenbrand, 2017/11/28
- [Qemu-devel] [PATCH v1 for-2.12 01/15] s390x/tcg: introduce and use program_interrupt_ra(), David Hildenbrand, 2017/11/28
- [Qemu-devel] [PATCH v1 for-2.12 02/15] s390x/tcg: get rid of runtime_exception(), David Hildenbrand, 2017/11/28
- [Qemu-devel] [PATCH v1 for-2.12 03/15] s390x/tcg: rip out dead tpi code, David Hildenbrand, 2017/11/28
- [Qemu-devel] [PATCH v1 for-2.12 05/15] s390x/pci: pass the retaddr to all PCI instructions, David Hildenbrand, 2017/11/28
- [Qemu-devel] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions, David Hildenbrand, 2017/11/28